feat: migrate to Node 24 LTS by marcoscaceres · Pull Request #481 · speced/respec-web-services

marcoscaceres · 2026-04-15T02:08:34Z

Closes #373

Summary

Bumps .nvmrc and CI to Node 24 LTS
Adds "engines": { "node": ">=24" } to package.json
Removes node-fetch dependency — replaced with the Node 24 built-in fetch
Replaces legacyDirname(import.meta) / legacyFilename(import.meta) helpers (and their fileURLToPath plumbing) with import.meta.dirname / import.meta.filename (available since Node 21.2)
Deletes the now-unused legacyDirname and legacyFilename exports from utils/misc.ts
Fixes pre-existing Express 5 req.params type errors (TS2345) in commits.ts, contributors.ts, and group.ts
Adds tests verifying fetch, import.meta.dirname, and import.meta.filename are available as globals, and that PROJECT_ROOT resolves correctly

Note

This PR touches some of the same files as #480 (the security hardening PR). It should be merged after #480 to avoid conflicts.

… 24, drop node-fetch

…e with import.meta, fix Express 5 param types

Copilot

Pull request overview

This PR migrates the service to Node.js 24 LTS, leveraging newer Node runtime features (built-in fetch, import.meta.dirname/import.meta.filename) and removing now-unneeded compatibility helpers/dependencies.

Changes:

Bump runtime/CI expectations to Node 24 (.nvmrc, GitHub Actions, package.json#engines).
Replace node-fetch and legacy import.meta path helpers with Node’s built-in fetch and import.meta.dirname/import.meta.filename.
Adjust Express 5 route param typing and add tests for Node 24 globals and PROJECT_ROOT.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
utils/misc.ts	Removes legacy dirname/filename helpers and related imports.
utils/constants.ts	Uses `import.meta.dirname` to compute `PROJECT_ROOT`.
utils/background-task-queue.ts	Switches worker bootstrap path to `import.meta.filename`.
scripts/update-w3c-groups-list.ts	Drops `node-fetch`/`fileURLToPath` usage; uses global `fetch` and `import.meta.filename`.
app.ts	Uses `import.meta.dirname` for views path.
routes/xref/update.ts	Uses `import.meta.dirname` for worker path.
routes/caniuse/update.ts	Uses `import.meta.dirname` for worker path.
routes/well-known/pay.ts	Removes `node-fetch` import (uses global `fetch`).
routes/w3c/group.ts	Adjusts Express 5 param typing; sets plain-text content type on invalid type.
routes/github/commits.ts	Adjusts Express 5 param typing and query typing; ensures plain-text in error path.
routes/github/contributors.ts	Adjusts Express 5 param typing.
routes/github/lib/utils/rest.ts	Removes `node-fetch` types; adds GitHub API URL validation; updates header typing.
routes/github/lib/utils/graphql.ts	Removes `node-fetch` import (uses global `fetch`).
routes/docs/update.ts	Removes `node-fetch` import (uses global `fetch`).
tests/node24-globals.test.js	Adds test assertions for Node 24 globals (`fetch`, `import.meta.dirname`, `import.meta.filename`).
tests/utils/constants.test.js	Adds coverage for `PROJECT_ROOT` resolution.
package.json	Adds Node >=24 engines constraint; removes `node-fetch` dependency.
pnpm-lock.yaml	Removes `node-fetch` and its transitive dependencies.
.nvmrc	Updates local Node version to 24.
.github/workflows/test.yml	Adds/updates CI to run on Node 24.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

routes/github/lib/utils/rest.ts:53

x-ratelimit-reset is a Unix timestamp in seconds, but new Date(number) expects milliseconds. As written, resetAt will be ~1000× earlier than intended, which can break any rate-limit/backoff logic that relies on resetAt. Convert the header value to milliseconds before constructing the Date.

function getRateLimit(headers: Headers): RateLimit {
  return {
    remaining: parseInt(headers.get("x-ratelimit-remaining") as string, 10),
    resetAt: new Date(parseInt(headers.get("x-ratelimit-reset") as string, 10)),
    limit: parseInt(headers.get("x-ratelimit-limit") as string, 10),

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/5e94febe-bb8b-4d99-86e6-050ffa3f7cb0 Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>

…e typing Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/dde0f0f2-efe1-43fc-b5df-d6bcdf6e4d53

marcoscaceres · 2026-04-15T08:48:25Z

@copilot, see @sidvishnoi's suggestions. Can you make the changes and also rebase?

…ecks Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/ccaf8248-161f-4e1c-be5b-c38f4c43bf24

Copilot · 2026-04-15T09:10:23Z

@copilot, see @sidvishnoi's suggestions. Can you make the changes and also rebase?

Applied @sidvishnoi’s suggestions in eb69200 (workflow action versions, required from query typing, and import.meta.main). Branch is synchronized with origin/feat/node24-migration.

marcoscaceres · 2026-04-15T09:32:57Z

@copilot Can you fix the ci issue?

Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/ddca0bfa-90d9-4424-a983-bdadec983e7d

Copilot · 2026-04-15T09:39:31Z

@copilot Can you fix the ci issue?

Fixed in 6d88026: I added a TypeScript ambient declaration for ImportMeta.main in @types/import-meta.d.ts, which addresses the CI build failure (TS2339 in scripts/update-w3c-groups-list.ts).

sidvishnoi · 2026-04-15T09:48:44Z

Does some lib in tsconfig not support it? Or updating @types/node?
Fine this way as well.

marcoscaceres added 3 commits April 15, 2026 12:05

feat: target Node 24 LTS — bump .nvmrc, add engines field, CI on Node…

9a4307d

… 24, drop node-fetch

refactor: replace node-fetch with native fetch, legacyDirname/Filenam…

5f5cff8

…e with import.meta, fix Express 5 param types

fix: apply XSS and SSRF security fixes from #480

7f5c397

marcoscaceres requested a review from Copilot April 15, 2026 02:29

Copilot started reviewing on behalf of marcoscaceres April 15, 2026 02:30 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread .github/workflows/test.yml Outdated

Comment thread routes/github/commits.ts Outdated

Comment thread routes/github/commits.ts

Comment thread routes/github/contributors.ts Outdated

Comment thread routes/w3c/group.ts Outdated

Copilot started work on behalf of marcoscaceres April 15, 2026 02:40 View session

Copilot AI and others added 2 commits April 15, 2026 02:42

fix: source CI Node version from .nvmrc

73896ca

Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/5e94febe-bb8b-4d99-86e6-050ffa3f7cb0 Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>

fix: address review feedback for node version source and commits rout…

20fe0f9

…e typing Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/dde0f0f2-efe1-43fc-b5df-d6bcdf6e4d53

Copilot finished work on behalf of marcoscaceres April 15, 2026 02:44

Copilot finished work on behalf of marcoscaceres April 15, 2026 02:45

refactor: use typed Request<Params> in contributors and group routes

bd6e4f1

marcoscaceres requested a review from sidvishnoi April 15, 2026 03:05

sidvishnoi reviewed Apr 15, 2026

View reviewed changes

Comment thread .github/workflows/test.yml Outdated

Comment thread .github/workflows/test.yml Outdated

Comment thread .github/workflows/test.yml Outdated

Comment thread routes/github/commits.ts Outdated

Comment thread scripts/update-w3c-groups-list.ts Outdated

sidvishnoi mentioned this pull request Apr 15, 2026

fix: address all open CodeQL security alerts #480

Merged

Copilot started work on behalf of marcoscaceres April 15, 2026 08:48 View session

chore: apply reviewer suggestions for workflow actions and runtime ch…

eb69200

…ecks Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/ccaf8248-161f-4e1c-be5b-c38f4c43bf24

Copilot finished work on behalf of marcoscaceres April 15, 2026 09:12

sidvishnoi approved these changes Apr 15, 2026

View reviewed changes

Merge branch 'main' into feat/node24-migration

02b41fe

Copilot started work on behalf of marcoscaceres April 15, 2026 09:33 View session

fix: add ImportMeta.main typing for CI TypeScript build

6d88026

Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/ddca0bfa-90d9-4424-a983-bdadec983e7d

Copilot finished work on behalf of marcoscaceres April 15, 2026 09:43

sidvishnoi reviewed Apr 15, 2026

View reviewed changes

marcoscaceres merged commit 373ce24 into main Apr 15, 2026
3 checks passed

marcoscaceres deleted the feat/node24-migration branch April 15, 2026 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: migrate to Node 24 LTS#481

feat: migrate to Node 24 LTS#481
marcoscaceres merged 9 commits into
mainfrom
feat/node24-migration

marcoscaceres commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcoscaceres commented Apr 15, 2026

Uh oh!

Copilot AI commented Apr 15, 2026

Uh oh!

marcoscaceres commented Apr 15, 2026

Uh oh!

Copilot AI commented Apr 15, 2026

Uh oh!

sidvishnoi Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

marcoscaceres commented Apr 15, 2026

Summary

Note

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcoscaceres commented Apr 15, 2026

Uh oh!

Copilot AI commented Apr 15, 2026

Uh oh!

marcoscaceres commented Apr 15, 2026

Uh oh!

Copilot AI commented Apr 15, 2026

Uh oh!

sidvishnoi Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants